Move queries that find related posts into a subcomponent #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/book-bazar/book-bazar/3qDAhGR7TxyJr871gyZPhkK5KQCW |
|
caleb, please let me know if you can still reproduce this issue from the book page. If you can't, I will go ahead and apply the same pattern to other pages to avoid the search bar breaking |
This reverts commit 2e0f9aa.
datho7561
force-pushed
the
149-prevent-reload-breaking-search
branch
from
2ed712f
to
f2ea0a5
Compare
…bcomponent" This reverts commit e51c2e0.
datho7561
force-pushed
the
149-prevent-reload-breaking-search
branch
from
f2ea0a5
to
97a85c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand, when any query present in the top level component in one of the pages updates, the page needs to re-render. When it does this, it re-renders the search bar as well, which removes any content currently added to it.
Unfortunately, since we have the mechanism to extend the header bar, it's not as simple as lifting out all the content of the page into a component.