-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm #59
base: main
Are you sure you want to change the base?
Helm #59
Conversation
Thanks @finaldzn! Can you fast forward the readme to include the most recent updates? re: the license env variable. There are a number of variables that need to be baked into the image at build time (known limitation of how calendly is trying to optimize use of runtime variables), this might be one of those. So it's on the radar for future, as long as we can specify a custom image path at helm install time. Please allow some time for testing and review on this one. Thank you for the help! |
Hello, |
Hey @krumware Have you manage to test deploying calendso on a K8S cluster using helm ? |
Hi @finaldzn, this is still on my list, sorry for the delay! |
My team might try to use this helm chart for deploying Calendso this week - we'll provide feedback along the way. |
@finaldzn FYI, there are some notable ENV variable changes incoming. you may want to keep an eye on my WIP pull request for the docker updates. Mainly NEXTAUTH_SECRET and NEXT_PUBLIC_WEBAPP_URL. In general, check out calcom/cal.com repo's .env.example |
@krumware Alright, are the env variable set up at runtime now or is it in the works ? Otherwise it limts a lot the uses for the helm chart. |
It's still a little bit muddy but things are evolving |
Is this pull request still in consideration? I plan to deploy cal to my kubernetes soon and would love to hear some feedback if I should wait for integration to master or go with the feature-branch? |
@krumware can you check? |
I need to update the branch, but it might need a few adjustement haven't followed the latest release. |
@PhilippKuntschik the branch needs to be updated to include updated changes, including env vars. I plan on taking a deeper dive this weekend as well as seeing if I can add Skaffold. |
@krumware by chance do you had time to look at this ? |
hey @finaldzn would you mind resolving the conflicts? 🙏 |
@PeerRich i think its done |
@krumware can you check and approve / merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deployment and values yamls need to be updated with the latest environmental variable changes
If possible, it would also be helpful to wrap the certificate resource in an optional flag or to remove it, since folks manage certificates in many different ways
@PhilippKuntschik You would need to take a look at the .env file and update the deployment.yaml and values.yaml file. Unfortunately I'm away from my computer and I can't do it right now. |
no worries, just don't want the PR to go stale. If there is an ETA without my help of lets say 2-8 weeks, that's fine with me. |
would it help if we cherry pick new changes into a new branch that you open? or should we merge this and you make a follow up PR? |
I think the fastest way would be if you merge the changes into a feature-branch that I can fork from to open a new PR? no need to cherry pick that way. |
@PhilippKuntschik Do you have any local changes for this that need to be pushed, or an active fork you want to reference? Thanks for the willingness to help here! attention is returning to this |
Hello again guys, are the runtime env variable ready ? Because otherwise there is no point in adding the extra env to the templates becuse they couldn't be changed anyway. Thanks |
Hey, any updates? I would love to use this :) |
Note that the docs should be adjusted here as well then: |
Hey @xeruf , I will try to finish the branch in the following days but there is the issue of some env variable not being set at runtime wich kind of defeats the purpose of the helm chart. If you have any idea how to fix this solution im all ears, but I'm going to proceed without it. |
Hey Guys, do you have a current status on this? We would need this as a helm chart. Can it be merged? |
Following |
Hello, I also needed this chart quickly for my own purpose. As I didn't receive response to join this repository, I created 2 charts on my own :
The env values are somehow sensitive, so I choose to store them into a secret to properly work. I also used the latest env parfile from the main project to get the latest environments variables as of today. For certificate, I let peoples create it and bind it with ingress, ingressClass, and annotation. There's plenty of ways to do it, mine is with Let's Encrypt (not in the repository). Please feel free to used it, inspire, contribute, etc. |
Hello,
In order to have calendso work on our deployment stack we have created a helm chart in order to deploy new build of the calendso docker image easily on kubernetes.
Any feedback is welcome.
The only issues we've had was concerning the licensce env variable that doesnt seem to work