Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm #59

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

Helm #59

wants to merge 66 commits into from

Conversation

finaldzn
Copy link

@finaldzn finaldzn commented Dec 22, 2021

Hello,
In order to have calendso work on our deployment stack we have created a helm chart in order to deploy new build of the calendso docker image easily on kubernetes.

Any feedback is welcome.

The only issues we've had was concerning the licensce env variable that doesnt seem to work

@krumware
Copy link
Member

Thanks @finaldzn!

Can you fast forward the readme to include the most recent updates?
Also, can you move the chart variables table and other relevant helm-specific items into a readme with the chart? We can link to those from the main readme to keep it clean.

re: the license env variable. There are a number of variables that need to be baked into the image at build time (known limitation of how calendly is trying to optimize use of runtime variables), this might be one of those. So it's on the radar for future, as long as we can specify a custom image path at helm install time.

Please allow some time for testing and review on this one. Thank you for the help!

@finaldzn
Copy link
Author

finaldzn commented Jan 3, 2022

Hello,
I've fast-forward the branch and moved around the readme for the helm chart
Let me know if you need anything else :)

@finaldzn
Copy link
Author

Hey @krumware Have you manage to test deploying calendso on a K8S cluster using helm ?

@krumware
Copy link
Member

Hi @finaldzn, this is still on my list, sorry for the delay!

@pat-s
Copy link

pat-s commented Jan 17, 2022

My team might try to use this helm chart for deploying Calendso this week - we'll provide feedback along the way.

@krumware
Copy link
Member

@finaldzn FYI, there are some notable ENV variable changes incoming. you may want to keep an eye on my WIP pull request for the docker updates. Mainly NEXTAUTH_SECRET and NEXT_PUBLIC_WEBAPP_URL. In general, check out calcom/cal.com repo's .env.example

@finaldzn
Copy link
Author

@krumware Alright, are the env variable set up at runtime now or is it in the works ? Otherwise it limts a lot the uses for the helm chart.

@krumware
Copy link
Member

It's still a little bit muddy but things are evolving

@PhilippKuntschik
Copy link

Is this pull request still in consideration? I plan to deploy cal to my kubernetes soon and would love to hear some feedback if I should wait for integration to master or go with the feature-branch?

@PeerRich
Copy link
Member

@krumware can you check?

@finaldzn
Copy link
Author

I need to update the branch, but it might need a few adjustement haven't followed the latest release.

@krumware
Copy link
Member

@PhilippKuntschik the branch needs to be updated to include updated changes, including env vars. I plan on taking a deeper dive this weekend as well as seeing if I can add Skaffold.

@vr
Copy link

vr commented Jul 25, 2022

@krumware by chance do you had time to look at this ?

@PeerRich
Copy link
Member

hey @finaldzn would you mind resolving the conflicts? 🙏
CleanShot 2022-07-25 at 10 32 28@2x

@finaldzn
Copy link
Author

@PeerRich i think its done

@PeerRich PeerRich requested a review from krumware July 25, 2022 10:14
@PeerRich
Copy link
Member

@krumware can you check and approve / merge?

Copy link
Member

@krumware krumware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployment and values yamls need to be updated with the latest environmental variable changes

If possible, it would also be helpful to wrap the certificate resource in an optional flag or to remove it, since folks manage certificates in many different ways

@PhilippKuntschik
Copy link

@finaldzn @krumware , I am not the author, but can I do something to get this merge request going? Can you point me to the "latest environmental variable changes" you are referring to?

@finaldzn
Copy link
Author

finaldzn commented Aug 9, 2022

@PhilippKuntschik You would need to take a look at the .env file and update the deployment.yaml and values.yaml file.

Unfortunately I'm away from my computer and I can't do it right now.

@PhilippKuntschik
Copy link

@PhilippKuntschik You would need to take a look at the .env file and update the deployment.yaml and values.yaml file.

Unfortunately I'm away from my computer and I can't do it right now.

no worries, just don't want the PR to go stale. If there is an ETA without my help of lets say 2-8 weeks, that's fine with me.
If I can help, I assume I would require access to either calcom/docker or medconnectmd/helm repository, is that right?

@PeerRich
Copy link
Member

PeerRich commented Aug 9, 2022

@PhilippKuntschik You would need to take a look at the .env file and update the deployment.yaml and values.yaml file.
Unfortunately I'm away from my computer and I can't do it right now.

no worries, just don't want the PR to go stale. If there is an ETA without my help of lets say 2-8 weeks, that's fine with me. If I can help, I assume I would require access to either calcom/docker or medconnectmd/helm repository, is that right?

would it help if we cherry pick new changes into a new branch that you open? or should we merge this and you make a follow up PR?

@PhilippKuntschik
Copy link

@PhilippKuntschik You would need to take a look at the .env file and update the deployment.yaml and values.yaml file.
Unfortunately I'm away from my computer and I can't do it right now.

no worries, just don't want the PR to go stale. If there is an ETA without my help of lets say 2-8 weeks, that's fine with me. If I can help, I assume I would require access to either calcom/docker or medconnectmd/helm repository, is that right?

would it help if we cherry pick new changes into a new branch that you open? or should we merge this and you make a follow up PR?

I think the fastest way would be if you merge the changes into a feature-branch that I can fork from to open a new PR? no need to cherry pick that way.

@krumware
Copy link
Member

@PhilippKuntschik Do you have any local changes for this that need to be pushed, or an active fork you want to reference? Thanks for the willingness to help here! attention is returning to this

@finaldzn
Copy link
Author

Hello again guys, are the runtime env variable ready ? Because otherwise there is no point in adding the extra env to the templates becuse they couldn't be changed anyway.

Thanks

@xeruf
Copy link

xeruf commented Feb 11, 2023

Hey, any updates? I would love to use this :)

@xeruf
Copy link

xeruf commented Feb 11, 2023

Note that the docs should be adjusted here as well then:
https://developer.cal.com/self-hosting/docker

@finaldzn
Copy link
Author

Hey @xeruf , I will try to finish the branch in the following days but there is the issue of some env variable not being set at runtime wich kind of defeats the purpose of the helm chart.

If you have any idea how to fix this solution im all ears, but I'm going to proceed without it.

@rhizoet
Copy link

rhizoet commented Jul 4, 2023

Hey Guys,

do you have a current status on this? We would need this as a helm chart. Can it be merged?

@Sundarasan
Copy link

Following

@Pyrrha
Copy link

Pyrrha commented Sep 17, 2023

Hello,

I also needed this chart quickly for my own purpose. As I didn't receive response to join this repository, I created 2 charts on my own :

  • calcom for running the application
  • cal com-stack for running it with a database

The env values are somehow sensitive, so I choose to store them into a secret to properly work. I also used the latest env parfile from the main project to get the latest environments variables as of today.

For certificate, I let peoples create it and bind it with ingress, ingressClass, and annotation. There's plenty of ways to do it, mine is with Let's Encrypt (not in the repository).

Please feel free to used it, inspire, contribute, etc.

👉 https://github.com/Pyrrha/calcom-helm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.