Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Doppler #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bvallelunga
Copy link

@bvallelunga bvallelunga commented Nov 15, 2021

Hey Cal community! Excited to add Doppler support for secure secrets management. Guide to using Doppler with Cal:

  1. Import our project to get setup.

    Import to Doppler
  2. Create a service token.

    create-service-token

  3. Build and start calendso with Doppler

    DOPPLER_TOKEN=dp.st.XXXXXXX docker-compose up --build

@PeerRich
Copy link
Member

thank you! we'll test this and get back to you. is doppler strictly required, no right?

@bvallelunga
Copy link
Author

That is correct. You can still use env files. This just fixes the Docker builds and adds support for Doppler.

@krumware
Copy link
Member

Personal opinion, but does Doppler belong embedded in the docker image? Absolutely not attacking Doppler, but in concept this adds proprietary functionality that might not work for folks who don't use Doppler. I'd rather see this added as part of an Examples or Advanced Usage section, if the concerns can be separated.

@bvallelunga
Copy link
Author

bvallelunga commented Nov 16, 2021

It's a great question I asked myself as well when building. Here was my thinking behind why I landed in the Dockerfile.

  • For Doppler to work due to how docker-compose works we will need the Doppler CLI to be available in the container. Wrapping the docker compose commands with doppler run sadly won't work as compose won't pass those environment variables to the containers.
  • The next question is do we install it at build-time or run-time. I chose build-time because if the CLI ever fails to download during the build there are no serious consequences compared to at runtime.

The way I structured the code is that Doppler is 100% optional to use. The Doppler CLI is very small so installing during the build shouldn't have a large impact on the size of the image. I also structured the README so it's a separate section called "Secrets Management".

@krumware
Copy link
Member

@bvallelunga is it ok if we table this temporarily while we resolve the current docker build issues? (i know you have some fixes embedded)

@bvallelunga
Copy link
Author

@krumware sure! Feel free to update the thread when you feel we are ready to resume. I can update the PR to just include the Doppler additions once the Docker issues have been fixed.

@bvallelunga
Copy link
Author

@krumware how's the Docker support going? Happy to resume working on this PR when you are ready.

@PeerRich
Copy link
Member

in touch with @krumware on slack!

@krumware
Copy link
Member

@bvallelunga can you join in on the calendso slack and we can chat about it?

@bvallelunga
Copy link
Author

Just joined the Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants