Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert People filter on /insights/routing from single select to multi select #18735

Draft
wants to merge 1 commit into
base: eunjae/cal-5013-improve-team-filter-component
Choose a base branch
from

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Jan 17, 2025

What does this PR do?

  • Fixes CAL-5049

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Try "People" filter on /insights/routing. You should be able to select more than one person.

Copy link

linear bot commented Jan 17, 2025

@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 17, 2025
@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5049-change-people-filter-from-single-to-multi-select branch from 544f10a to 4a27aa9 Compare January 17, 2025 17:02
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:06pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 5:06pm

@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5049-change-people-filter-from-single-to-multi-select branch from 4a27aa9 to 68adea7 Compare January 17, 2025 17:06
@eunjae-lee
Copy link
Contributor Author

This PR is ready for review, but please do not merge, because this PR is stacked on #18655. I will merge this PR after I merge that.

Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice and clean :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants