feat: routing forms integration for booker atom #18726
Open
+196
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Ryukemeister
changed the title
Graphite Automations"Add platform team as reviewer" took an action on this PR • (01/17/25)1 reviewer was added to this PR based on Keith Williams's automation. |
| @@ -22,6 +22,8 @@ export const useAvailableSlots = ({ | |||
| rest.isTeamEvent ?? false, | |||
| rest.teamId ?? false, | |||
| rest.usernameList, | |||
| rest.routedTeamMemberIds, | |||
| rest.skipContactOwner, | |||
There was a problem hiding this comment.
we are missing shouldServeCache here, no?
There was a problem hiding this comment.
ah yes, will fix this one
There was a problem hiding this comment.
salesforce related query param is also missing.
There was a problem hiding this comment.
I don't see the salesforce parameter in the schema of the trpc endpoint for slots here packages/trpc/server/routers/viewer/slots/types.ts is it used at all ?
There was a problem hiding this comment.
Added some comments to explain why some parameters are left out here
…success-for-platform' into remove-redirect-on-success-for-platform
dosubot
bot
added
routing-forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
loom video - https://app.campsite.com/cal/posts/8wh9mtl0s9ug#comment-tgoolr4bxzz3
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
This can be tested in the examples app