Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump libphonenumber version #18724

Closed
wants to merge 5 commits into from

Conversation

alishaz-polymath
Copy link
Member

@alishaz-polymath alishaz-polymath commented Jan 17, 2025

What does this PR do?

Bumps libphonenumber version to 1.11.18
Fixes #18703
Removes patch libphonenumber-js-npm-1.10.51-4ff79b15f8.patch and adds libphonenumber-js+1.11.18.patch for latest version. This patch is essential to allow us access isValidPhoneNumber via lazy load of libphonenumber-js

Mandatory Tasks (DO NOT REMOVE)

  • N/A I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 6:22am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 6:22am

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jan 17, 2025
Copy link

socket-security bot commented Jan 17, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@github-actions github-actions bot added booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working labels Jan 20, 2025
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected]

View full report↗︎

@alishaz-polymath alishaz-polymath marked this pull request as ready for review January 20, 2025 06:00
@graphite-app graphite-app bot requested a review from a team January 20, 2025 06:00
@dosubot dosubot bot added the ⬆️ dependencies Pull requests that update a dependency file label Jan 20, 2025
Copy link

graphite-app bot commented Jan 20, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (01/20/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@alishaz-polymath
Copy link
Member Author

Something weird with the yarn lockfile. Will reopen a fresh PR.

@alishaz-polymath
Copy link
Member Author

#18757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working core area: core, team members only ⬆️ dependencies Pull requests that update a dependency file enterprise area: enterprise, audit log, organisation, SAML, SSO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libphonenumber-js version out of date. Australian numbers starting with +614943 are not validating in Calcom
2 participants