-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: react incompatiblity with nextjs error #18433
Conversation
@retrogtx is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/01/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (01/01/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (01/01/25)1 label was added to this PR based on Keith Williams's automation. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !! Thanks @retrogtx 🙏
thank you and happy new years! |
E2E results are ready! |
What does this PR do?
Updated the peer dependencies in
@calcom/embed-react
to support both Rect 18 and 19. This change allows the embed component to work with Nextjs projects which use React 19.since the codebase is huge,
No errors regarding react compatibility anymore.
Mandatory Tasks (DO NOT REMOVE)