Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: react incompatiblity with nextjs error #18433

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

retrogtx
Copy link
Contributor

@retrogtx retrogtx commented Jan 1, 2025

What does this PR do?

Updated the peer dependencies in @calcom/embed-react to support both Rect 18 and 19. This change allows the embed component to work with Nextjs projects which use React 19.

since the codebase is huge,

  • the change updates peer dependencies to accept both React 18 and React 19 versions
  • it also maintains backward compatibility with existing React 18 applications

image
image
No errors regarding react compatibility anymore.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Jan 1, 2025

@retrogtx is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 1, 2025
@graphite-app graphite-app bot requested a review from a team January 1, 2025 03:55
@github-actions github-actions bot added ⬆️ dependencies Pull requests that update a dependency file 🐛 bug Something isn't working labels Jan 1, 2025
Copy link

graphite-app bot commented Jan 1, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/01/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/01/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/01/25)

1 label was added to this PR based on Keith Williams's automation.

@retrogtx retrogtx changed the title fix: react incompatiblity with nextjs error fix #18399: react incompatiblity with nextjs error Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fix #18399: react incompatiblity with nextjs error". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@retrogtx retrogtx changed the title fix #18399: react incompatiblity with nextjs error fix: react incompatiblity with nextjs error Jan 1, 2025
Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks @retrogtx 🙏

@retrogtx
Copy link
Contributor Author

retrogtx commented Jan 1, 2025

LGTM !! Thanks @retrogtx 🙏

thank you and happy new years!

Copy link
Contributor

github-actions bot commented Jan 1, 2025

E2E results are ready!

@emrysal emrysal merged commit 02a49e2 into calcom:main Jan 3, 2025
55 of 81 checks passed
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync ⬆️ dependencies Pull requests that update a dependency file ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer dependencies pinned to React 18.2 incompatible with latest nextjs
3 participants