Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type error in app/api/customer-card/route.ts #18431

Closed
wants to merge 1 commit into from

Conversation

cnhhoang850
Copy link
Contributor

What does this PR do?

Fix type error during build due to exporting handler function instead where route handlers should only export HTTP methods

Type error: Route "app/api/customer-card/route.ts" does not match the required types of a Next.js Route. "handler" is not a valid Route export field.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Yarn build

Copy link

vercel bot commented Dec 31, 2024

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 31, 2024
@graphite-app graphite-app bot requested a review from a team December 31, 2024 12:47
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fix type error in app/api/customer-card/route.ts". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the 🐛 bug Something isn't working label Dec 31, 2024
@cnhhoang850 cnhhoang850 changed the title Fix type error in app/api/customer-card/route.ts fix: type error in app/api/customer-card/route.ts Dec 31, 2024
Copy link

graphite-app bot commented Dec 31, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/31/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/31/24)

1 label was added to this PR based on Keith Williams's automation.

@Praashh
Copy link
Contributor

Praashh commented Dec 31, 2024

We don't need this atm, everything's fine in app/api/customer-card/route.ts, closing it for now 🙏

@Praashh Praashh closed this Dec 31, 2024
@emrysal
Copy link
Contributor

emrysal commented Dec 31, 2024

Thank you - there's a few more; About to open up a PR could you review this? CC @Praashh @cnhhoang850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants