feat: Add dry run mode message during the booking process. #18429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
bookings
keithwillcode
added
core
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/31/24)1 reviewer was added to this PR based on Keith Williams's automation. |
hariombalhara
commented
Dec 31, 2024
| @@ -464,7 +469,7 @@ const nextConfig = { | |||
| }, | |||
| { | |||
| source: "/icons/sprite.svg", | |||
| headers: [CORP_CROSS_ORIGIN_HEADER], | |||
| headers: [CORP_CROSS_ORIGIN_HEADER, ACCESS_CONTROL_ALLOW_ORIGIN_HEADER], | |||
There was a problem hiding this comment.
This fixes the issue of icons not appearing locally for org bookings.
Production endpoint already has this header, I don't know why(maybe cloudflare)
hariombalhara
force-pushed
the
feat-add-banner-dry-run
branch
from
7de5fac to
fbab72c
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hariombalhara
force-pushed
the
feat-add-banner-dry-run
branch
from
fbab72c to
02c64b0
Compare
…rocess - Introduced a new `DryRunMessage` component to inform users when in dry run mode. - Implemented utility function `isBookingDryRun` to check for dry run status based on URL search parameters. - Updated the `Booker` component to conditionally render the dry run message. - Adjusted booking mutation input mapping to reuse the utility
hariombalhara
force-pushed
the
feat-add-banner-dry-run
branch
from
02c64b0 to
b7a3fae
Compare
E2E results are ready! |
Udit-takkar
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo - https://www.loom.com/share/7649e3db7c08404683fd882f226c74cc
DryRunMessagecomponent to inform users when in dry run mode.isBookingDryRunto check for dry run status based on URL search parameters.Bookercomponent to conditionally render the dry run message.What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
See loom