Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate /403 and /500 pages to App Router #18424

Merged
merged 7 commits into from
Dec 31, 2024
Merged

chore: Migrate /403 and /500 pages to App Router #18424

merged 7 commits into from
Dec 31, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Dec 31, 2024 •
edited
Loading

What does this PR do?

  • Migrate /403 and /500 pages to App Router

Tested /403

Screenshot 2024-12-30 at 22 16 15

Tested /500

Screenshot 2024-12-30 at 22 16 07

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Please use the latest Vercel preview and test please 🙏.

@vercel Vercel
Copy link

vercel bot commented Dec 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 31, 2024 3:18am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 31, 2024 3:18am

@graphite-app graphite-app bot requested a review from a team December 31, 2024 03:01
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 31, 2024
@hbjORbj hbjORbj changed the title chore: app router error pages chore: Migrate /403 and /500 pages to App Router Dec 31, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 31, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/31/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj enabled auto-merge (squash) December 31, 2024 03:17
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

hariombalhara
hariombalhara approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@hbjORbj hbjORbj merged commit 557bd8b into main Dec 31, 2024
37 checks passed
@hbjORbj hbjORbj deleted the chore/app-router-error-pages branch December 31, 2024 06:13
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
@hbjORbj @MuhammadAimanSulaiman
chore: Migrate /403 and /500 pages to App Router (calcom#18424)
777d7ef 
* global-error is not needed

* remove /403 and /500 pages from pages router

* add 403 and 500 pages in App Router

* add i18n strings

* fix i18n string

* fix styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariombalhara hariombalhara hariombalhara approved these changes

Assignees
No one assigned
Labels
consumer core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @hariombalhara @keithwillcode