Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump alby packages #18406

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Dec 29, 2024

What does this PR do?

This updates Alby packages used for being able to book paid meetings with lightning.

There is a bug in the previous version of lightning-tools which means invoices cannot be generated for alby accounts connected to self-custodial nodes (such as Alby Hub).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [N/A] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Dec 29, 2024

@rolznz is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 29, 2024
@graphite-app graphite-app bot requested review from a team December 29, 2024 04:22
@dosubot dosubot bot added the ⬆️ dependencies Pull requests that update a dependency file label Dec 29, 2024
Copy link

graphite-app bot commented Dec 29, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (12/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/29/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/30/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link

socket-security bot commented Dec 29, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

yarn.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also have before and after fix recording ?

@rolznz rolznz force-pushed the chore/bump-alby-packages-2 branch from 5565149 to ed077f3 Compare December 29, 2024 13:16
@rolznz
Copy link
Contributor Author

rolznz commented Dec 29, 2024

can we also have before and after fix recording ?

I don't have a recording right now, but here is the fix of the error before and afterward, running node from node_modules/@getalby/lightning-tools/dist directory.

BEFORE:

> const {LightningAddress} = await import("./index.cjs");
undefined
> const ln = new LightningAddress("[email protected]");
undefined
> await ln.fetch();
Uncaught TypeError: Cannot use 'in' operator to search for 'customKey' in undefined

AFTER

> const {LightningAddress} = await import("./index.cjs");
undefined
> const ln = new LightningAddress("[email protected]");
undefined
> await ln.fetch();
undefined

@Praashh
Copy link
Contributor

Praashh commented Dec 30, 2024

Looks good to me

@PeerRich PeerRich enabled auto-merge (squash) January 6, 2025 10:50
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] network 0 549 kB panva

🚮 Removed packages: npm/@formkit/[email protected]

View full report↗︎

Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the yarn.lock file

@keithwillcode
Copy link
Contributor

Build is failing https://github.com/calcom/cal.com/actions/runs/12631167071/job/35193080835?pr=18406#step:5:590

@keithwillcode keithwillcode marked this pull request as draft January 6, 2025 14:16
auto-merge was automatically disabled January 6, 2025 14:16

Pull request was converted to draft

@rolznz
Copy link
Contributor Author

rolznz commented Jan 14, 2025

@keithwillcode why was the PR marked as draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ⬆️ dependencies Pull requests that update a dependency file ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants