Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump alby packages #18405

Closed
wants to merge 1 commit into from
Closed

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Dec 29, 2024

What does this PR do?

This updates Alby packages used for being able to book paid meetings with lightning.

There is a bug in the previous version of lightning-tools which means invoices cannot be generated for alby accounts connected to self-custodial nodes (such as Alby Hub).

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Dec 29, 2024

@rolznz is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 29, 2024
@graphite-app graphite-app bot requested review from a team December 29, 2024 04:10
@dosubot dosubot bot added the ⬆️ dependencies Pull requests that update a dependency file label Dec 29, 2024
Copy link

graphite-app bot commented Dec 29, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (12/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/29/24)

1 label was added to this PR based on Keith Williams's automation.

@rolznz
Copy link
Contributor Author

rolznz commented Dec 29, 2024

closing, I forgot to get the latest on main. I'll create a new PR.

@rolznz rolznz closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ⬆️ dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant