Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce mobile navigation bottom margin #18398

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Reduce mobile navigation bottom margin

This PR reduces the bottom margin of the mobile navigation from 0.625rem to 0.25rem while maintaining PWA safe-area-inset functionality.

Changes

  • Reduced padding-bottom in mobile navigation from 0.625rem to 0.25rem
  • Maintained PWA safe-area-inset compatibility
  • Only affects mobile view (md:hidden class ensures desktop is unaffected)

Testing

Due to development environment setup issues (missing NEXTAUTH_SECRET), local testing was not possible. However, the change is minimal and follows existing patterns:

  • Maintains all existing classes and functionality
  • Only modifies the numeric value in max() function
  • Preserves PWA safe-area-inset logic

Link to Devin run: https://app.devin.ai/sessions/7229634087a44be9ab06003c5292a41f

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Dec 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2024 9:06am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2024 9:06am

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 28, 2024
@graphite-app graphite-app bot requested a review from a team December 28, 2024 09:05
@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Dec 28, 2024
Copy link

graphite-app bot commented Dec 28, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/28/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/28/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

E2E results are ready!

@PeerRich PeerRich merged commit 3f0a671 into main Dec 28, 2024
57 of 81 checks passed
@PeerRich PeerRich deleted the devin/1735376695-reduce-mobile-bottom-nav-margin branch December 28, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant