-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add typeform logo and fix alt text in /apps/typeform/how-to-use #18393
fix: add typeform logo and fix alt text in /apps/typeform/how-to-use #18393
Conversation
@ShashankGupta10 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/27/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (12/27/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (12/28/24)1 label was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
E2E results are ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ShashankGupta10 , E2E tests are failing, can you please fix this ?
I dont know why it's failing. Looked in the logs, found this. But I am not sure if it is because of my PR. Because it is actually just changing a text and an image. |
please try running tests locally 🙏 |
Pull request was converted to draft
…18393) * 🚚: add typeform logo and fix alt text * trying to fix the test * Update testUtils.ts --------- Co-authored-by: Anik Dhabal Babu <[email protected]> Co-authored-by: unknown <[email protected]>
…alcom#18393) * 🚚: add typeform logo and fix alt text * trying to fix the test * Update testUtils.ts --------- Co-authored-by: Anik Dhabal Babu <[email protected]> Co-authored-by: unknown <[email protected]>
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist