Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add typeform logo and fix alt text in /apps/typeform/how-to-use #18393

Merged

Conversation

ShashankGupta10
Copy link
Contributor

What does this PR do?

image

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Typeform Image appears and also alt text is correct just in case. Can be verified in UI

Checklist

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 27, 2024
@graphite-app graphite-app bot requested a review from a team December 27, 2024 21:39
@CLAassistant
Copy link

CLAassistant commented Dec 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

vercel bot commented Dec 27, 2024

@ShashankGupta10 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Dec 27, 2024
@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Dec 27, 2024
Copy link
Contributor

github-actions bot commented Dec 27, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "  fix: add typeform logo and fix alt text in /apps/typeform/how-to-use". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

graphite-app bot commented Dec 27, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/27/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/28/24)

1 label was added to this PR based on Keith Williams's automation.

@ShashankGupta10 ShashankGupta10 changed the title 🚚: add typeform logo and fix alt text fix: add typeform logo and fix alt text in /apps/typeform/how-to-use Dec 27, 2024
@ShashankGupta10 ShashankGupta10 changed the title fix: add typeform logo and fix alt text in /apps/typeform/how-to-use fix: add typeform logo and fix alt text in /apps/typeform/how-to-use Dec 27, 2024
@Praashh Praashh self-assigned this Dec 28, 2024
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

github-actions bot commented Dec 28, 2024

E2E results are ready!

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ShashankGupta10 , E2E tests are failing, can you please fix this ?

@ShashankGupta10
Copy link
Contributor Author

I dont know why it's failing. Looked in the logs, found this.
[WebServer] error connecting to engine: sql, type: postgres db: error: password authentication failed for user "postgres"

But I am not sure if it is because of my PR. Because it is actually just changing a text and an image.

@Praashh
Copy link
Contributor

Praashh commented Dec 28, 2024

I dont know why it's failing. Looked in the logs, found this. [WebServer] error connecting to engine: sql, type: postgres db: error: password authentication failed for user "postgres"

But I am not sure if it is because of my PR. Because it is actually just changing a text and an image.

please try running tests locally 🙏

@anikdhabal anikdhabal disabled auto-merge December 29, 2024 03:29
@anikdhabal anikdhabal enabled auto-merge (squash) December 29, 2024 03:30
@github-actions github-actions bot added the Low priority Created by Linear-GitHub Sync label Dec 29, 2024
@anikdhabal anikdhabal marked this pull request as draft December 29, 2024 07:21
auto-merge was automatically disabled December 29, 2024 07:21

Pull request was converted to draft

@anikdhabal anikdhabal marked this pull request as ready for review December 29, 2024 15:05
@dosubot dosubot bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Dec 29, 2024
@anikdhabal anikdhabal enabled auto-merge (squash) December 29, 2024 15:05
@anikdhabal anikdhabal requested a review from Praashh December 30, 2024 03:34
@anikdhabal anikdhabal merged commit 55113f2 into calcom:main Dec 30, 2024
32 of 36 checks passed
@ShashankGupta10 ShashankGupta10 deleted the shashank/fix-typeform-logo-issue branch December 30, 2024 05:45
joeauyeung pushed a commit that referenced this pull request Jan 5, 2025
…18393)

* 🚚: add typeform logo and fix alt text

* trying to fix the test

* Update testUtils.ts

---------

Co-authored-by: Anik Dhabal Babu <[email protected]>
Co-authored-by: unknown <[email protected]>
MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Jan 10, 2025
…alcom#18393)

* 🚚: add typeform logo and fix alt text

* trying to fix the test

* Update testUtils.ts

---------

Co-authored-by: Anik Dhabal Babu <[email protected]>
Co-authored-by: unknown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working community Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeform logo not found in /apps/typeform/how-to-use
4 participants