-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: removed the confirm step in creating bookings #18380
base: main
Are you sure you want to change the base?
Conversation
@theVedanta is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/27/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (12/27/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (12/27/24)1 label was added to this PR based on Keith Williams's automation. |
also can you please add a loom recording of the fix @theVedanta 🙏 ? |
I've added it in the first comment or the PR description. |
Alright, thanks! One thing I wanted to ask is, if someone accidentally clicks the button, it’ll immediately book the meeting. I think it would be better to have a confirmation dialog box or something similar to prevent this. |
This has been discussed in the GitHub issue before. Please check the issue once and let me know if a dialog box is required. |
yeah, got the answer, thank you 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a test case for this feature @theVedanta?
Sure, can you please provide some context and more information on how you want the tescases generaeted? |
What does this PR do?
Removed the confirm step changes in this PR because as I see it, once the URL params are passed and checked in the useEffect, the booking state is changed, where I've replaced it with the handleEventBooking();
Mandatory Tasks (DO NOT REMOVE)
LOOM LINK: https://www.loom.com/share/2967cdb902fb4945908e17c79bb379b8?sid=88459728-1b9e-46e9-af1a-9168cd8cc0cc
How should this be tested?
You can start by creating event types with varying complexity and check if any URL params are conflicting this direct booking without confirmation.
No ENV vars required to test.