Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed the confirm step in creating bookings #18380

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

theVedanta
Copy link

@theVedanta theVedanta commented Dec 27, 2024

What does this PR do?

Removed the confirm step changes in this PR because as I see it, once the URL params are passed and checked in the useEffect, the booking state is changed, where I've replaced it with the handleEventBooking();

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [N/A] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

LOOM LINK: https://www.loom.com/share/2967cdb902fb4945908e17c79bb379b8?sid=88459728-1b9e-46e9-af1a-9168cd8cc0cc

How should this be tested?

You can start by creating event types with varying complexity and check if any URL params are conflicting this direct booking without confirmation.

No ENV vars required to test.

Copy link

vercel bot commented Dec 27, 2024

@theVedanta is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested review from a team December 27, 2024 02:49
@CLAassistant
Copy link

CLAassistant commented Dec 27, 2024

CLA assistant check
All committers have signed the CLA.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 27, 2024
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "added functionality to remove the confirm step in creating bookings". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added High priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Dec 27, 2024
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking ❗️ migrations contains migration files labels Dec 27, 2024
Copy link

graphite-app bot commented Dec 27, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (12/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/27/24)

1 label was added to this PR based on Keith Williams's automation.

@theVedanta theVedanta changed the title added functionality to remove the confirm step in creating bookings feat: removed the confirm step in creating bookings Dec 27, 2024
yarn.lock Outdated Show resolved Hide resolved
@Praashh
Copy link
Contributor

Praashh commented Dec 27, 2024

also can you please add a loom recording of the fix @theVedanta 🙏 ?

packages/prisma/.env Outdated Show resolved Hide resolved
@theVedanta
Copy link
Author

also can you please add a loom recording of the fix @theVedanta 🙏 ?

I've added it in the first comment or the PR description.

@Praashh
Copy link
Contributor

Praashh commented Dec 27, 2024

also can you please add a loom recording of the fix @theVedanta 🙏 ?

I've added it in the first comment or the PR description.

Alright, thanks! One thing I wanted to ask is, if someone accidentally clicks the button, it’ll immediately book the meeting. I think it would be better to have a confirmation dialog box or something similar to prevent this.

@theVedanta
Copy link
Author

also can you please add a loom recording of the fix @theVedanta 🙏 ?

I've added it in the first comment or the PR description.

Alright, thanks! One thing I wanted to ask is, if someone accidentally clicks the button, it’ll immediately book the meeting. I think it would be better to have a confirmation dialog box or something similar to prevent this.

This has been discussed in the GitHub issue before. Please check the issue once and let me know if a dialog box is required.

@Praashh
Copy link
Contributor

Praashh commented Dec 28, 2024

also can you please add a loom recording of the fix @theVedanta 🙏 ?

I've added it in the first comment or the PR description.

Alright, thanks! One thing I wanted to ask is, if someone accidentally clicks the button, it’ll immediately book the meeting. I think it would be better to have a confirmation dialog box or something similar to prevent this.

This has been discussed in the GitHub issue before. Please check the issue once and let me know if a dialog box is required.

yeah, got the answer, thank you 🙏

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test case for this feature @theVedanta?

@theVedanta
Copy link
Author

Can we have a test case for this feature @theVedanta?

Sure, can you please provide some context and more information on how you want the tescases generaeted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync ✨ feature New feature or request High priority Created by Linear-GitHub Sync ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4943] If all information for "confirm" step is provided skip step
3 participants