Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade jsforce to 3.6.2 and use jsforce-node #18363

Merged
merged 30 commits into from
Jan 9, 2025
Merged

chore: Upgrade jsforce to 3.6.2 and use jsforce-node #18363

merged 30 commits into from
Jan 9, 2025

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Dec 24, 2024 •
edited
Loading

What does this PR do?

  • Upgrades jsforce version from v1.11.0 to v3.6.3

  • Uses jsforce-node. A more slimmed down version of jsforce without the browser specific bloat

  • Fixes #XXXX (GitHub issue number)

  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 24, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 7:38pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 7:38pm

@socket-security Socket Security
Copy link

socket-security bot commented Dec 24, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@joeauyeung joeauyeung marked this pull request as ready for review December 27, 2024 17:35
@graphite-app graphite-app bot requested a review from a team December 27, 2024 17:35
@dosubot dosubot bot added crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ⬆️ dependencies Pull requests that update a dependency file labels Dec 27, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 27, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (12/31/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 27, 2024 •
edited
Loading

E2E results are ready!

@joeauyeung
Copy link
Contributor Author

@zomars there's no tests specifically that test the library as we mock returns. I have been developing against this branch though and haven't run into any errors.

@zomars
Copy link
Member

zomars commented Jan 7, 2025

Seems like we have a failure related with platform

@joeauyeung
Copy link
Contributor Author

I'm currently talking with @ThyMinimalDev and @emrysal about it.

emrysal
emrysal previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooo

@socket-security Socket Security
Copy link

socket-security bot commented Jan 9, 2025 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

View full report↗︎

@keithwillcode keithwillcode enabled auto-merge (squash) January 9, 2025 19:45
@keithwillcode keithwillcode merged commit 2a29155 into main Jan 9, 2025
38 checks passed
@keithwillcode keithwillcode deleted the upgrade-jsforce-v3 branch January 9, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomars zomars zomars left review comments

@keithwillcode keithwillcode keithwillcode approved these changes

@emrysal emrysal emrysal left review comments

Assignees
No one assigned
Labels
consumer core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ⬆️ dependencies Pull requests that update a dependency file ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joeauyeung @ThyMinimalDev @zomars @emrysal @keithwillcode @anikdhabal