chore: ignore oAuthClientId for Booker Embed bookings #18314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
bot
added
the
bookings
keithwillcode
added
core
Graphite Automations"Add platform team as reviewer" took an action on this PR • (12/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
As I understand by this campsite thread, this is supposed to resolve platform booker ambed not sending emails, but if we remove the client id header in this PR, then emails would not be sent. Isn't the solution to make sure that the OAuth client used for booker embed has emails enabled ? |
E2E results are ready! |
supalarry
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding X_CAL_PLATFORM_EMBED which is set in the CalProvider when Embed atoms are used.
we then use this header in booking controller to know when to ignore oauth client settings while sending emails. this ensures similar behaviour than on web.
Mandatory Tasks (DO NOT REMOVE)