Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong Meeting Ended payload in zapier #18202

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: wrong Meeting Ended payload in zapier #18202

wants to merge 7 commits into from
+49 −5

Conversation

kart1ka
Copy link
Contributor

@kart1ka kart1ka commented Dec 16, 2024

What does this PR do?

Screenshot 2024-12-16 at 3 50 42 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team December 16, 2024 10:23
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 16, 2024
@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload labels Dec 16, 2024
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Dec 16, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 16, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/16/24)

1 label was added to this PR based on Keith Williams's automation.

@kart1ka kart1ka marked this pull request as draft December 16, 2024 12:20
Praashh
Praashh requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing can we fix this?

@kart1ka kart1ka marked this pull request as ready for review December 17, 2024 09:12
@kart1ka
Copy link
Contributor Author

kart1ka commented Dec 17, 2024

Unit tests are failing can we fix this?

done.

@kart1ka
Copy link
Contributor Author

kart1ka commented Dec 31, 2024

Hey @Praashh
Just checking on the status of this PR.
Do let me know if any changes need to be made.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praashh Praashh Praashh requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-4820] Wrong payload 'Meeting ended' zapier
2 participants
@kart1ka @Praashh