chore: app router - /event-types pages #18181
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
| @@ -281,7 +240,7 @@ const EventTypeWeb = ({ | |||
| } as const; | |||
|
|
|||
| useHandleRouteChange({ | |||
| watchTrigger: isAppDir ? pageRouter : pathname, | |||
There was a problem hiding this comment.
seems like we used an opposite conditional here
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/14/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (12/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
changed the title
E2E results are ready! |
| export type { | ||
| FormValues, | ||
| CustomInputParsed, | ||
| EventTypeSetup, | ||
| EventTypeSetupProps, | ||
| Host, | ||
| } from "@calcom/features/eventtypes/lib/types"; |
There was a problem hiding this comment.
Confirmed that these are not imported from this file anywhere
| const EventTypeAppWrapper = ({ id, ...rest }: EventTypeSetupProps & { id: number }) => { | ||
| const pathname = usePathname(); | ||
| const router = useAppRouter(); | ||
| return ( | ||
| <EventTypeWeb | ||
| {...rest} | ||
| id={id} | ||
| isAppDir={true} | ||
| pathname={pathname ?? ""} | ||
| pageRouter={null} | ||
| appRouter={router} | ||
| /> | ||
| ); | ||
| return <EventTypeWeb {...rest} id={id} pathname={pathname ?? ""} appRouter={router} />; |
There was a problem hiding this comment.
I think we can shift this logic in EventTypeWebWrapper directly and remove this component completely
| @@ -258,8 +258,6 @@ test.describe("Manage Booking Questions", () => { | |||
|
|
|||
| await test.step("Go to First Team Event", async () => { | |||
| await page.getByTestId(`horizontal-tab-${team?.name}`).click(); | |||
| await page.waitForLoadState("networkidle"); | |||
There was a problem hiding this comment.
await page.waitForLoadState("networkidle"); is likely to never resolve in App Router because there are constantly likely to be network activities in App Router (e.g., streaming server components)
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?