Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hydration error in [org-slug]/[team-slug], [org-slug]/[team-slug]/[type] pages #17576

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vijayraghav-io
Copy link
Contributor

@vijayraghav-io vijayraghav-io commented Nov 11, 2024

What does this PR do?

fixes hydration error due to nested anchor elements.

Before Fix / Issue :
https://www.loom.com/share/20d314a3952c47a4a53b252a5eb79edc?sid=a145ef5f-d97a-4d34-8cc7-882e8a91b05c

After Fix :
https://www.loom.com/share/c72b274adc8441c498d2a8165dc478db?sid=bcc7d554-328b-4bb0-adcd-76e2ff626dd9

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • - N/A -I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Nov 11, 2024

@vijayraghav-io is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team November 11, 2024 08:41
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Nov 11, 2024
@github-actions github-actions bot added the 🐛 bug Something isn't working label Nov 11, 2024
@dosubot dosubot bot added the automated-tests area: unit tests, e2e tests, playwright label Nov 11, 2024
Copy link

graphite-app bot commented Nov 11, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/11/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions github-actions bot added organizations area: organizations, orgs teams area: teams, round robin, collective, managed event-types labels Nov 11, 2024
@vijayraghav-io vijayraghav-io changed the title fix: hydration error in [org-slug]/team, [org-slug]/team/[team-slug]/[type] pages fix: hydration error in [org-slug]/[team-slug], [org-slug]/[team-slug]/[type] pages Nov 11, 2024
@vijayraghav-io
Copy link
Contributor Author

vijayraghav-io commented Nov 11, 2024

Ready!

@Udit-takkar Udit-takkar added this to the v4.7 milestone Nov 12, 2024
@Praashh Praashh self-assigned this Nov 15, 2024
@keithwillcode keithwillcode modified the milestones: v4.7, v4.8 Nov 18, 2024
@dosubot dosubot bot modified the milestone: v4.8 Nov 18, 2024
@Praashh
Copy link
Contributor

Praashh commented Nov 19, 2024

Hey @vijayraghav-io can you please attach a loom video of the fix.

@vijayraghav-io
Copy link
Contributor Author

Hey @vijayraghav-io can you please attach a loom video of the fix.

Attached before and after fix videos in description.

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, tagging @anikdhabal for a final review before approving.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Dec 6, 2024
@vijayraghav-io
Copy link
Contributor Author

Gentle Reminder!

Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Dec 30, 2024
@vijayraghav-io
Copy link
Contributor Author

Gentle Reminder! for review

@github-actions github-actions bot removed the Stale label Dec 31, 2024
@dosubot dosubot bot modified the milestones: v4.9, v4.10 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright 🐛 bug Something isn't working community Created by Linear-GitHub Sync organizations area: organizations, orgs teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4746] Hydration error on org/team page
4 participants