chore: app router - all sub-pages in /apps
#16976
Draft
+544
−521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/07/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
This PR is being marked as stale due to inactivity. |
hbjORbj
force-pushed
the
chore/apps-remove-pages-router-1
branch
from
b1501ff to
5587b8f
Compare
hbjORbj
changed the title
/apps
3 tasks
github-actions
bot
added
Medium priority
|
hbjORbj
commented
Jan 6, 2025
| {page} | ||
| </Shell> | ||
| ); | ||
| return <Shell withoutMain={true}>{page}</Shell>; |
There was a problem hiding this comment.
Removed backPath as it is irrelevant when withoutMain is true
| {page} | ||
| </Shell> | ||
| ); | ||
| return <Shell withoutMain={true}>{page}</Shell>; |
There was a problem hiding this comment.
Removed backPath as it is irrelevant when withoutMain is true
| {page} | ||
| </Shell> | ||
| ); | ||
| return <Shell withoutMain={true}>{page}</Shell>; |
There was a problem hiding this comment.
Removed backPath as it is irrelevant when withoutMain is true
hbjORbj
commented
Jan 6, 2025
Comment on lines
+617
to
+619
| source: "/apps/routing-forms/:path*", | ||
| destination: "/routing/:path*", | ||
| permanent: true, |
There was a problem hiding this comment.
redirecting /apps/routing-forms paths to /routing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?