feat: checkbox to count managed events for team-wide limits #16923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2024 11:08
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
CarinaWolli
added
High priority
CarinaWolli
commented
Oct 4, 2024
| @@ -369,10 +429,10 @@ describe( | |||
|
|
|||
| const { req: req2 } = createMockNextJsRequest({ | |||
| method: "POST", | |||
| body: mockBookingData1, | |||
| body: mockBookingData2, | |||
There was a problem hiding this comment.
the wrong mockBookingData was used here
There was a problem hiding this comment.
can we rename the variable to some self-explanatory to prevent this from happening again?
| @@ -468,10 +557,9 @@ describe( | |||
|
|
|||
| const { req: req2 } = createMockNextJsRequest({ | |||
| method: "POST", | |||
| body: mockBookingData1, | |||
| body: mockBookingData2, | |||
There was a problem hiding this comment.
same, wrong mockBookingData was used
CarinaWolli
commented
Oct 4, 2024
| @@ -123,6 +129,8 @@ const _getBusyTimesFromBookingLimits = async (params: { | |||
| teamId, | |||
| user, | |||
| rescheduleUid, | |||
| includeManagedEvents, | |||
| timeZone, | |||
There was a problem hiding this comment.
not passing timeZone here caused this error with yearly booking limits:
dosubot
bot
added
teams
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/04/24)1 reviewer was added to this PR based on Keith Williams's automation. |
zomars
previously approved these changes
Oct 4, 2024
hbjORbj
reviewed
Oct 4, 2024
packages/features/bookings/lib/handleNewBooking/global-booking-limits.test.ts
Outdated
Show resolved
Hide resolved
| @@ -369,10 +429,10 @@ describe( | |||
|
|
|||
| const { req: req2 } = createMockNextJsRequest({ | |||
| method: "POST", | |||
| body: mockBookingData1, | |||
| body: mockBookingData2, | |||
There was a problem hiding this comment.
can we rename the variable to some self-explanatory to prevent this from happening again?
E2E results are ready! |
hbjORbj
approved these changes
Oct 7, 2024
hbjORbj
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a checkbox to team-wide bookings limits so admins can choose if bookings from managed event types are counted for the time-wide booking limits.
Also fixes the following bug:
How to reproduce bug?
Mandatory Tasks (DO NOT REMOVE)