-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix custom scrollbar in Calendar description #16780
Conversation
…bar in the calendar description.
…bar in the calendar description.
@Benny-intoleads is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/24/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (09/24/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (09/24/24)1 label was added to this PR based on Keith Williams's automation. |
@tailwind base; | ||
@tailwind components; | ||
@tailwind utilities; | ||
|
||
/* globals.css */ | ||
|
||
/* Scrollbar styles */ | ||
::-webkit-scrollbar { | ||
width: 12px; | ||
} | ||
|
||
::-webkit-scrollbar-track { | ||
border: 1px solid rgb(231, 232, 229); | ||
border-radius: 10px; | ||
} | ||
|
||
::-webkit-scrollbar-thumb { | ||
background:rgb(231, 232, 229); | ||
border-radius: 10px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? Not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Benny-intoleads pls uncommit the lock file
|
@Benny-intoleads sorry, but it's fine now. Tested it |
What does this PR do?
Adds custom scrollbar styling for the
EventMetaBlock
component.Implements
max-h-[180px]
andoverflow-y-auto
to ensure the scrollbar appears only when content exceeds 180px.Adds global styles for custom WebKit scrollbars in
globals.css
.Fixes the issue where the scrollbar was not visible when content overflowed.
Fixes Calendar description does not have visible scrollbar to indicate more content #16757 (GitHub issue number)
Fixes CAL-Calendar description does not have visible scrollbar to indicate more content #16757(Linear issue number - should be visible at the bottom of the GitHub issue description)
Loom Video:https://www.loom.com/share/35dbe5e6c5094b4bb0019378883c282e?sid=64a8bcaa-42d0-4810-ba79-3941d41cbbbd
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Steps to Reproduce
Verify scrollbar appearance:
Are there environment variables that should be set?
No environment variables are required to test this PR. It relies on frontend styling, so no backend or environment-specific configurations are needed.
What are the minimal test data to have?
Minimal test data:
A block of text or HTML content that exceeds 180px in height is necessary to trigger the scrollbar.
What is expected (happy path) to have (input and output)?
Input: A container with content that exceeds 180px in height, triggering the scrollbar.
Expected output (happy path):
The scrollbar appears on the right side of the container.
The scrollbar track is styled as defined (light border, rounded corners).
The scrollbar thumb is styled with a default color (rgb(231, 232, 229)).
On hover, the scrollbar thumb changes color (#88ba1c).
The scrollbar should be smooth, functional, and should only appear when the content exceeds the defined height limit.
Any other important info that could help to test that PR
-Responsive behaviour: Ensure that the component behaves correctly on various screen sizes. The max-h-[180px] class should work across devices.
-Cross-browser testing: While the custom scrollbar styles are primarily for WebKit-based browsers, testers should also
-check how the component looks in Firefox to ensure the native scrollbar does not break the layout.
Edge cases:
-Test with content that is exactly 180px in height to ensure the scrollbar does not appear.
-Test with content significantly larger than 180px to ensure the scrollbar behaves correctly without overlapping or layout
issues.
-Test hover behaviour and confirm that the thumb colour change on the hover is smooth and works as expected.
Checklist