-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Use "standalone" output to build Next.js as a standalone app #14852
Conversation
…ng built e.g. in Docker.
@jckw is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add community label" took an action on this PR • (05/02/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/02/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This PR is being marked as stale due to inactivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to give this a shot, if this does create issues (which will be caught by our checks) we should consider an environment variable like so:
output: process.env.BUILD_STANDALONE === "true" ? "standalone" : undefined,
Hi @jckw I'm unable to update this branch (critical to do so as the checks will not run properly otherwise) - will close and re-open a mirror. |
What does this PR do?
This PR changes the Next.js output type of the @calcom/web app to "standalone", which is needed if calcom/docker#355 is to merge.
The "output" config property should not affect builds being run on Vercel, but will affect those built with Docker.
Please see the linked PR for a full explanation of why this is useful. The summary is:
Requirement/Documentation
Type of change
How should this be tested?
Test out this branch on whatever build process is used by Cal (presumably Vercel), and verify that it works and deploys. Unless there is any special config used by Cal, everything should work as normal on Vercel.
Mandatory Tasks
Checklist