Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bg emphasis darkmdoe #12909

Closed
wants to merge 1 commit into from
Closed

Conversation

sean-brydon
Copy link
Member

fixes: CAL-2834 #12888

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 1:56am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 1:56am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 1:56am
cal-demo ⬜️ Ignored (Inspect) Dec 21, 2023 1:56am
ui ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 1:56am

Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 163.02 KB (🟢 -1.25 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eighteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 249.95 KB 412.97 KB 117.99% (🟢 -2.59%)
/[user]/[type]/embed 249.98 KB 413 KB 118.00% (🟢 -2.59%)
/auth/verify 102.67 KB 265.69 KB 75.91% (🟢 -11.26%)
/availability 421.79 KB 584.81 KB 167.09% (🟡 +0.16%)
/bookings/[status] 312.32 KB 475.34 KB 135.81% (🟢 -0.16%)
/d/[link]/[slug] 249.79 KB 412.81 KB 117.95% (🟢 -2.59%)
/getting-started/[[...step]] 402.24 KB 565.26 KB 161.50% (🟡 +0.14%)
/org/[orgSlug]/[user]/[type] 250.17 KB 413.19 KB 118.05% (🟢 -2.59%)
/org/[orgSlug]/[user]/[type]/embed 250.2 KB 413.21 KB 118.06% (🟢 -2.59%)
/org/[orgSlug]/team/[slug]/[type] 249.82 KB 412.84 KB 117.95% (🟢 -2.59%)
/settings/admin/organizations 252.62 KB 415.64 KB 118.75% (🟢 -0.30%)
/settings/developer/webhooks/[id] 257.2 KB 420.22 KB 120.06% (🟢 -0.16%)
/settings/developer/webhooks/new 257.26 KB 420.28 KB 120.08% (🟢 -0.16%)
/settings/organizations/members 419.59 KB 582.61 KB 166.46% (🟡 +0.18%)
/settings/teams/new 181.03 KB 344.05 KB 98.30% (🟢 -2.08%)
/signup 144.61 KB 307.63 KB 87.89% (🟢 -0.15%)
/team/[slug]/[type] 249.78 KB 412.8 KB 117.94% (🟢 -2.59%)
/team/[slug]/[type]/embed 249.81 KB 412.83 KB 117.95% (🟢 -2.59%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@@ -51,7 +51,7 @@
.dark {
/* background */

--cal-bg-emphasis: hsla(0, 0%, 32%, 1);
--cal-bg-emphasis: hsla(0, 0%, 32%,1);
Copy link
Contributor

@Udit-takkar Udit-takkar Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sean-brydon isn't this same as before? just without space between comma and 1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ermmm yes - very confused as this was wrong for me locally - just merged and it’s this like someone beat me to it

@emrysal
Copy link
Contributor

emrysal commented Dec 21, 2023

Closing as it's already done (with correct space :))

@emrysal emrysal closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants