Merge pull request #254 from cal-itp/fix-file-presence

try to work around mutate resulting in nans
cal-itp · May 18, 2023 · 8dba33c · 8dba33c
2 parents 79804af + 582e7fc
commit 8dba33c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/reports/generate_reports_data.py b/reports/generate_reports_data.py
@@ -9,7 +9,7 @@
 from calitp_data_analysis.sql import get_engine  # type: ignore
 from siuba import _, arrange, collect  # type: ignore
 from siuba import filter as filtr  # type: ignore
-from siuba import if_else, mutate, pipe, rename, select, spread  # type: ignore
+from siuba import mutate, pipe, rename, select, spread  # type: ignore
 from siuba.sql import LazyTbl  # type: ignore
 from tqdm import tqdm
 
@@ -149,8 +149,14 @@ def generate_file_check(itp_id: int, publish_date):
         >> rename(success=_.file_present)
         >> rename(name=_.filename)
         >> rename(category=_.reason)
+    )
+
+    file_check.success = file_check.success.apply(lambda v: "✅" if v else "")
+    # replacing this in mutate call
+    #     success=if_else(_.success == True, "✅", ""),  # noqa: E712
+    file_check = (
+        file_check
         >> mutate(
-            success=if_else(_.success == True, "✅", ""),  # noqa: E712
             date_checked=_.date_checked.astype(str),
         )
         >> spread(_.date_checked, _.success)

diff --git a/tests/schemas/schema_1_feed_info.json b/tests/schemas/schema_1_feed_info.json
@@ -39,7 +39,7 @@
         "no_service_days_ct": {
            "anyOf": [
             {
-              "type": "integer"
+              "type": "number"
             },
             {
               "type": "null"