Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust ci #326

Merged
merged 1 commit into from
Dec 12, 2024
Merged

adjust ci #326

merged 1 commit into from
Dec 12, 2024

Conversation

LordSimal
Copy link
Contributor

@LordSimal LordSimal commented Dec 12, 2024

I ran https://github.com/woodruffw/zizmor on the current CI config and got the following output:

🌈 completed ci.yml
warning[artipacked]: credential persistence through GitHub Actions artifacts
  --> /Users/kevin/Documents/CakePHP/Org/elastic-search/.github/workflows/ci.yml:39:7
   |
39 |     - uses: actions/checkout@v2
   |       ------------------------- does not set persist-credentials: false
   |
   = note: audit confidence → Low

warning[artipacked]: credential persistence through GitHub Actions artifacts
   --> /Users/kevin/Documents/CakePHP/Org/elastic-search/.github/workflows/ci.yml:108:7
    |
108 |     - uses: actions/checkout@v3
    |       ------------------------- does not set persist-credentials: false
    |
    = note: audit confidence → Low

info[template-injection]: code injection via template expansion
  --> /Users/kevin/Documents/CakePHP/Org/elastic-search/.github/workflows/ci.yml:71:7
   |
71 |     - name: Setup problem matchers for PHPUnit
   |       ---------------------------------------- info: this step
72 |       if: matrix.php-version == '8.1'
73 |       run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
   |       ---------------------------------------------------------------- info: runner.tool_cache may expand into attacker-controllable code
   |
   = note: audit confidence → Low

13 findings (10 suppressed): 0 unknown, 1 informational, 0 low, 2 medium, 0 high

@LordSimal LordSimal merged commit 5987010 into 4.x Dec 12, 2024
3 checks passed
@LordSimal LordSimal deleted the 4.x-adjust-ci branch December 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant