Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cake electrs fork updates #2

Open
wants to merge 3 commits into
base: cake-update-v1
Choose a base branch
from
Open

Cake electrs fork updates #2

wants to merge 3 commits into from

Commits on Aug 2, 2024

  1. only return tweaks with unspent outputs 

    Only send a txid:tweak object if the output_pubkeys array has at least
one unspent output. Otherwise, we end up having the client download
a lot of data they will never use.
    @josibake
    josibake committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    447a194 View commit details
    Browse the repository at this point in the history

  2. collect all outpoints from the transaction 

    The smallest outpoint is chosen from all of the transaction inputs, not
just the silent payment eligible inputs (see BIP352). In practice, most
wallets will be spending the same input types together so its likely
that the set of silent payments eligible inputs will be the same as the
set of transaction inputs. Wallets can, however, add non-eligible
inputs, such as OP_CHECKMULTISIG inputs.

Fix by collecting all outpoints before filtering for the silent payments
eligible inputs.
    @josibake
    josibake committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e53563d View commit details
    Browse the repository at this point in the history

  3. update hardcoded start height, remove panic 

    70,000 is way too early, update to 800,000 which is after taproot
activation and a little before the first BIP352 transactions appear on
chain.

Ideally, this start height should be network specific considering
taproot has always been activated on signet.

Leave a comment to fix this in a followup.
    @josibake
    josibake committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    a91d19a View commit details
    Browse the repository at this point in the history