Support centered map without marker #118
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The location field might seem currently required, as there is always a marker on the map. It can be difficult so to track when the address has not been found for example, or when the user didn't touch the marker.
This tries to surround that by introducing a new option:
map.center
. If the field has no value, instead of using0,0
as default - or setting an initial value which can disturb the user - the marker is hidden and the map is panned to this position. As soon as the user click on the map or a location is found, the marker is shown. However, if the field has a value, the current behavior is kept andmap.center
is not taken into account.What do you think? If you approve that, my next plan is to allow one to override this value at model, form or widget level...
Note that there will be a conflict if #117 is merged that I will fix.