Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Manifests #15

Merged
merged 11 commits into from
Jun 14, 2019
Merged

Conversation

anoopwebs
Copy link
Contributor

What this PR does / why we need it:

One part for #7

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes # #7

Reference to #

Special notes for your reviewer:

/cc @your-reviewer

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. labels Jun 12, 2019
@anoopwebs
Copy link
Contributor Author

/assign @supereagle

@anoopwebs anoopwebs changed the title Kubernetes files Kubernetes Manifests Jun 12, 2019
@supereagle
Copy link
Member

@anoopwebs Thanks for your great work. I'd prefer to put them into deploy folder, then it is easier for users to find them. WDYT?

example/deploy.yaml Outdated Show resolved Hide resolved
@supereagle
Copy link
Member

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2019
@caicloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supereagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2019
@caicloud-bot caicloud-bot merged commit cfb6577 into caicloud:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants