Skip to content
This repository has been archived by the owner on Sep 29, 2024. It is now read-only.

feat: Add bare events page #223

Merged
merged 36 commits into from
Aug 1, 2024
Merged

feat: Add bare events page #223

merged 36 commits into from
Aug 1, 2024

Conversation

ArshiLamba
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Breaking Change
  • Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@vercel Vercel
Copy link

vercel bot commented Jul 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
greenbites ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 3:08pm
greenbites-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 3:08pm

@github-actions github-actions bot added Scope: Server This change affects the server. Scope: Client This change affects the client. Scope: Utilities This change affects utilities. labels Jul 27, 2024
github-actions[bot]
github-actions bot reviewed Jul 27, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution! 🥳

@ArshiLamba ArshiLamba closed this Jul 27, 2024
@ArshiLamba ArshiLamba reopened this Jul 27, 2024
caffeine-addictt
caffeine-addictt suggested changes Jul 27, 2024
View reviewed changes
Copy link
Owner

@caffeine-addictt caffeine-addictt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArshiLamba

  • As mentioned before. Split this PR up; 1 for the DB schema, 1 for the rest.
  • Fix your formatting.
  • Populate the PR template so I can review all these quicker

server/src/db/schemas.ts Outdated Show resolved Hide resolved
shared/api-types/src/schemas/event.ts Outdated Show resolved Hide resolved
server/src/v1/route-map.ts Outdated Show resolved Hide resolved
server/src/v1/event.ts Outdated Show resolved Hide resolved
client/src/pages/route-map.tsx Outdated Show resolved Hide resolved
client/src/pages/user/eventlist.tsx Outdated Show resolved Hide resolved
client/src/pages/user/route-map.tsx Outdated Show resolved Hide resolved
client/src/pages/user/route-map.tsx Outdated Show resolved Hide resolved
server/src/v1/event.ts Outdated Show resolved Hide resolved
server/src/v1/event.ts Outdated Show resolved Hide resolved
@caffeine-addictt caffeine-addictt added this to the Group project review milestone Jul 27, 2024
@caffeine-addictt caffeine-addictt changed the title Feature/events feat: Add bare events page Jul 27, 2024
This was referenced Jul 27, 2024
Merged
Closed
Merged
@caffeine-addictt caffeine-addictt merged commit 5812808 into main Aug 1, 2024
11 checks passed
@caffeine-addictt caffeine-addictt deleted the feature/events branch August 1, 2024 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@caffeine-addictt caffeine-addictt caffeine-addictt approved these changes

Assignees

@ArshiLamba ArshiLamba

Labels
Scope: Client This change affects the client. Scope: Server This change affects the server. Scope: Utilities This change affects utilities.
Projects
None yet
Milestone
Group project review
Development

Successfully merging this pull request may close these issues.
2 participants
@ArshiLamba @caffeine-addictt