Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model equations for simple dead end filtration model #10

Merged

Conversation

daklauss
Copy link
Member

@daklauss daklauss commented Aug 2, 2024

Reopened Pull request after i merged too fast.

First implementation of the easy def model as described in #5, stil wip

TODOS:

  • Tests
    • Residual tests
    • Test unit Operation
  • Considering outsourcing to rejection base class?
    • Use rejection class in def
    • Test rejection class?

@daklauss daklauss self-assigned this Aug 2, 2024
CADETPythonSimulator/residual.py Outdated Show resolved Hide resolved
CADETPythonSimulator/residual.py Outdated Show resolved Hide resolved
CADETPythonSimulator/residual.py Outdated Show resolved Hide resolved
CADETPythonSimulator/residual.py Outdated Show resolved Hide resolved
CADETPythonSimulator/residual.py Outdated Show resolved Hide resolved
CADETPythonSimulator/residual.py Outdated Show resolved Hide resolved
CADETPythonSimulator/unit_operation.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@daklauss daklauss force-pushed the add-model-equations-for-simple-dead-end-filtration-model branch from e1902b2 to b8ec415 Compare August 14, 2024 11:51
@schmoelder schmoelder marked this pull request as ready for review August 14, 2024 13:27
@daklauss daklauss force-pushed the add-model-equations-for-simple-dead-end-filtration-model branch 3 times, most recently from 80ab06f to 13850f9 Compare August 21, 2024 08:01
@schmoelder schmoelder force-pushed the add-model-equations-for-simple-dead-end-filtration-model branch from 13850f9 to 3b37b05 Compare August 21, 2024 08:49
@schmoelder schmoelder force-pushed the add-model-equations-for-simple-dead-end-filtration-model branch from 3b37b05 to 40c072d Compare August 21, 2024 08:50
@daklauss daklauss merged commit 40c072d into master Aug 28, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants