Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregation and breakage to crystallization module #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented Jul 9, 2024

There are multiple branches with parts of the functionality that we want, i.e. sole aggregation, sole breakage, sole PBM and all of them combined. However, the code is not modular.
The respective branches are on @WFlynnZ fork of CADET.
We need to figure out a neat modularization and then incorporate the code from the aforementioned branches, which we will do on this branch here.

Before we start:

Smolouchowski Coagulation Equation:

  • add code
  • add documentation
  • add tests

Fragmentation Equation:

  • add code
  • add documentation
  • add tests

@WFlynnZ
Copy link
Collaborator

WFlynnZ commented Oct 7, 2024

Things to consider when modularize the current code @jbreue16 :

  1. Aggregation, Breakage and PBM (Population Balance with Mass Balance) should be able to be solved independently, and combined with two or three together.
  2. Because Aggregation and Breakage are mass-conserving, the mass balance equation (and also PBM) is not needed when solving them independently.
  3. When solving the PBM, two additional components are added: solute concentration is the first component and the solubility is the last component. These two components are absent in the Aggregation and Breakage code. When changing code, need to make sure the residual and Jacobian are also adapted.

Possible combinations are:

  1. Aggregation
  2. Breakage
  3. PBM
  4. Aggregation, Breakage
  5. Aggregation, PBM
  6. Breakage, PBM
  7. Aggregation, Breakage, PBM

Only 1, 2, and 4 don't have the two additional components.

This substitutes the part I paper in the emphasized citing section
@jbreue16 jbreue16 force-pushed the feature/crystallization_agg_brk branch from 1b1e733 to 7412f7d Compare November 20, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants