Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more parameter dependencies #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented Apr 19, 2024

We have started adding parameter dependencies (both state and paramter dependece) in #120

There are still desirable dependencies that are not implemented yet.
Furthermore, we decided to change the return logic of the parameter dependencies to return the values itself, not a modifying prefactor

  • expand tests
  • DG units parameter dependencies as in FV units
  • Film diffusion in GRM (check what weve done there back then and bug fix)
  • Change return logic of parameter dependencies so that the value itself is returned, not a factor (done but double check)
  • Register parameters s.t. they can be read when reading all parameters
  • Add flag to return parameter trajectory over time in output.

jbreue16 and others added 2 commits May 8, 2024 15:45
Logic changed such that the parameter value itself is returned, instead of a modifying factor

Co-authored-by: schmoelder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant