-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Binding model #186
base: master
Are you sure you want to change the base?
Custom Binding model #186
Conversation
Following the tutorial for custom binding model and trying to add the custom binding model Test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Without having tested your code (or checked the math), I added some comments that I would ask you to address before we can accept any PR.
Let us know if you have any questions.
.github/workflows/ci.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not remove the CI files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not remove the CI files
@@ -1,4 +1,4 @@ | |||
CADET | |||
CADET (my version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename your model and give it a more descriptive name. Note, this also involves changing the file names in other places, e.g. CMake files.
Test binding model trying to be implamented is the same as the one here, but with Langmuir replaced with Test.