Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Binding model #186

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Custom Binding model #186

wants to merge 3 commits into from

Conversation

Daniel-H2
Copy link

Test binding model trying to be implamented is the same as the one here, but with Langmuir replaced with Test.

Daniel-H2 and others added 2 commits April 17, 2024 16:05
Following the tutorial for custom binding model and trying to add the custom binding model Test.
Copy link
Contributor

@schmoelder schmoelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Without having tested your code (or checked the math), I added some comments that I would ask you to address before we can accept any PR.

Let us know if you have any questions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not remove the CI files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not remove the CI files

@@ -1,4 +1,4 @@
CADET
CADET (my version)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename your model and give it a more descriptive name. Note, this also involves changing the file names in other places, e.g. CMake files.

@ronald-jaepel ronald-jaepel marked this pull request as draft June 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants