Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for TestWorkflowMutableStateImpl #979

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Test for TestWorkflowMutableStateImpl #979

merged 1 commit into from
Nov 28, 2024

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Nov 28, 2024

What changed?

  • Added tests for TestWorkflowMutableStateImpl
  • Detracted validation methods to static functions as they are not using the instance variables anyway
  • Split one validation method in two so one validates and the other mutates

Why?
Increase code coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

3vilhamster
3vilhamster approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! It is not only unit tests but also improving code structure/mix of responsibilities and weird internalization.

@3vilhamster 3vilhamster merged commit 2da5fe4 into cadence-workflow:master Nov 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3vilhamster 3vilhamster 3vilhamster approved these changes

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@abhishekj720 abhishekj720 Awaiting requested review from abhishekj720 abhishekj720 is a code owner

@natemort natemort Awaiting requested review from natemort natemort is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobht @3vilhamster