Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coveralls integration and generate metadata for Sonarqube #952

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

natemort
Copy link
Member

@natemort natemort commented Nov 7, 2024

What changed?

  • Provide coverage and test results as buildkite metadata
  • Remove coveralls integration as we no longer use it.

Why?

  • Allow Uber's internal CI/Sonarqube to pull in data from cadence-java-client

How did you test it?

  • Creating this PR 😄

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.28%. Comparing base (6d76d41) to head (2210ebe).
Report is 6 commits behind head on master.

Additional details and impacted files

see 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d8ef8...2210ebe. Read the comment docs.

@@ -52,7 +52,8 @@ steps:

- label: ":java: Unit test with test services"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add codecov label to readme similar to server repo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@natemort natemort merged commit 2332262 into cadence-workflow:master Nov 7, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants