Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestbody: Type-based error handling for MaxBytesError #6701

Merged
merged 3 commits into from
Nov 22, 2024
Merged

requestbody: Type-based error handling for MaxBytesError #6701

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9a4a20
fix: handle "request body too large" error using type assertion
rishitashaw Nov 22, 2024
42a3c0c
fix: address overlooked nil check for MaxBytesError
rishitashaw Nov 22, 2024
6194f5a
fix: replace type assertion with errors.As() for MaxBytesError
rishitashaw Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/caddyhttp/requestbody/requestbody.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package requestbody

import (
"errors"
"io"
"net/http"
"time"
Expand Down Expand Up @@ -94,7 +95,8 @@ type errorWrapper struct {

func (ew errorWrapper) Read(p []byte) (n int, err error) {
n, err = ew.ReadCloser.Read(p)
if err != nil && err.Error() == "http: request body too large" {
var mbe *http.MaxBytesError
if errors.As(err, &mbe) {
err = caddyhttp.Error(http.StatusRequestEntityTooLarge, err)
}
return
Expand Down
Loading