Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade dependencies #6675

Closed
wants to merge 1 commit into from
Closed

chore: Upgrade dependencies #6675

wants to merge 1 commit into from

Conversation

francislavoie
Copy link
Member

Mostly to test if CI likes this better or not.

@francislavoie francislavoie added the CI/CD 🔩 Automated tests, releases label Nov 4, 2024
@francislavoie
Copy link
Member Author

I'm super confused. We're not really doing anything wrong.

@mohammed90
Copy link
Member

The goreleaser check uses master, which is why we still see reference to [email protected] in the error trace. I think both our PRs fix it, just the check in the PR action doesn't show it because neither of them are in master. Either of them work. I'll let you choose. The only issue with this PR is the last yolo commit, if you may revert that.

@francislavoie
Copy link
Member Author

Yours looks fine

@mohammed90 mohammed90 deleted the deps-upgrade branch November 5, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francislavoie @mohammed90