Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Go 1.21 and run go mod tidy #49

Merged

Conversation

KeisukeYamashita
Copy link
Contributor

Why

First of all, thank you for your amazing job.
This provider (module) makes it easier to handle the ACME challenges.

To maintain to the latest version as much as possible, I ran go mod tidy -go=1.22.

Thank you in advance.

Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita KeisukeYamashita changed the title chore: bump go 1.22 and run go mod tidy chore: bump Go 1.22 and run go mod tidy Jul 15, 2024
@KeisukeYamashita KeisukeYamashita marked this pull request as ready for review July 15, 2024 14:15
Signed-off-by: KeisukeYamashita <[email protected]>
@KeisukeYamashita
Copy link
Contributor Author

@aymanbagabas Hello, sorry for bothering you.
Could you please take a look when you get a chance?

Thank you for your wonderful project!

Copy link
Collaborator

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Match caddyserver go version

.github/workflows/build.yml Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@aymanbagabas aymanbagabas merged commit 5de7485 into caddy-dns:master Jul 19, 2024
2 checks passed
@KeisukeYamashita KeisukeYamashita changed the title chore: bump Go 1.22 and run go mod tidy chore: bump Go 1.21 and run go mod tidy Jul 19, 2024
@KeisukeYamashita
Copy link
Contributor Author

Thanks!
I've updated the title to match to the update!

@KeisukeYamashita KeisukeYamashita deleted the bump-go-version-to-1.22 branch July 31, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants