perf: reduce memory allocations #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-mayer
added
the
housekeeping
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR aims to reduce memory reallocations by refactoring for loops which append to slices to resize the underlying array where ever possible.
Additionally it removes unnecessary temporary copies in the get resource functions.
This is in theory slightly going to improve performance and efficiency. It wouldn't hurt to go over the whole project and try to find more places where memory allocations could be avoided. That's a lot of work though and its not like the downscaler has performance issues so it would just be a nice to have.
Changes
Tests done
TODO