Support steam p2p sockets #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvbg
force-pushed
the
steam-p2p
branch
5 times, most recently
from
ba21cc9 to
b4b2c48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
+ Coverage 67.43% 67.44% +0.01%
==========================================
Files 159 159
Lines 10436 10440 +4
==========================================
+ Hits 7037 7041 +4
Misses 3399 3399 ☔ View full report in Codecov by Sentry. |
|
|
||
| // NOTE: it looks like there's SingleClient can actually be called on multiple threads | ||
| // - https://partner.steamgames.com/doc/api/steam_api#SteamAPI_RunCallbacks | ||
| pub(crate) struct SingleClientThreadSafe(steamworks::SingleClient); |
There was a problem hiding this comment.
So do you think it would be possible to use this as a wrapper to the user's provided SteamworksClient to avoid the Arc<RwLock>?
|
Looks great to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Steam P2P sockets. This has been tested by @zwazel and is confirmed to at least work partially, though with some kinks (#243).
I didn't add tests for this since that would require Steam to be installed to run tests.