Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back custom driver tests #11249

Open
wants to merge 130 commits into
base: master
Choose a base branch
from

Conversation

gblaih
Copy link
Contributor

@gblaih gblaih commented Dec 3, 2024

No description provided.

haynescd and others added 30 commits November 23, 2024 23:28
* Add Columnar SQL file to init Clickhouse DB

* Refactored Mapper xml to extract StudyViewFilterMapper
* ✅ Add Unit test for StudyViewMapper Clickhouse

* ✅ Update db props to include mysql and clickhouse datasources to fix tests

* Address comments

* Rename package to clickhouse

* Update to static final

* Use bean name instead of qualifier
…10803)

* Create new wide table sql file and rename package

* Remove genomic_event view

* Add AlterationFilter to mutated_genes endpoint

* Add AlterationFilter to mutated-genes endpoint

* Fix unit test

* Fix sonar issues

* Add test for mutation types and status

* remove unused imports
* add missing poc clinical data binning function
* Add sample_mv materialized view and use it in mappers
…al#10824)

* Add Support for TotalProfiledCase Counts for Mutated-genes endpoint.

* Create sql files to create new tables

* Add unit test for totalProfiledCount

* Add matching gene panel ids

* Add TotalProfiledCountsWithoutPanelData

* Add profileCount for genes without gene panel data

* Add Comments for SQL

* Update matching Gene Panel Ids

* Clean up code

* Fix test

* Add query to get correct Gene Panels

* Fix unit test

* Add comments
* working poc

* refactor logic into service, so clean

* refactor for parameters builder, simplify min max logic, streamline service call

* remove unused services and imports

* remove more unused imports
* Implement molecular profile count endpoint using Clickhouse

* Cleanup
* ✨ Add CNA Gene Endpoint

* 🐛 Fix StudyViewFilterMapper.xml to allow ability to filter on gene and alteration

* Fix merge conflict

* Address comments

* Fix unit tests

* Fix sonar issues
* ✨ Add StructuralVariant-genes endpoint

* Fix sonar issues

* Update MatchingGenePanel request to return list

* Create and use sample_derive

* Update where sample_derived is stored to fix unit test
* use clinical_data_derived instead of sample_clinical_attribute_numeric_mv and patient_clinical_attribute_numeric_mv

* use clinical_attribute_meta instead of sample_clinical_attribute_numeric_mv and patient_clinical_attribute_numeric_mv

* remove unused clinical data count methods and SQL

* fix numericalClinicalDataCountFilter

* Move CategoricalClinicalAttributeFilter to repository

* remove unused columns

* Add override to methods

---------

Co-authored-by: haynescd <[email protected]>
…ioPortal#10857)

* Add patient_id column to genomic_event_derived

* Update sql to convert list of patients to list of samples
* refactor to use clickhouse

* filter out empty attr values

* edit comment

* fix sonarcloud issues

* use parallel stream, shaves off 5s

* use newer mapping annotation
* simplify clinical data binning related SQL

* fix numericalClinicalDataCountFilter
* Add Clinical Events Timeline counts endpoint

* Add comments for StudyViewFilter
* Fix alteration count services

* Only add genes that are protein coding to gene_panel_to_gene table for WES

* fix test

* fix sonar issues

* Add documentation for filtering out WES
zainasir and others added 26 commits November 23, 2024 23:40
Use PR-specific image for circleci api tests
)

* Hide select properties of ClinicalDataFilter from frontend

* Update swagger decorators on clickhouse controller
…cBioPortal#11155)

* Add patient level filtering for aggregation

* Patient level filtering works for non-NA

* Categorical patient level filtering & clean up

* Use new generic assay table schema
…y clickhouse_enabled is set (cBioPortal#11256)

* Update cBioPortal to dynamically load ch Components only when property clickhouse_enabled is set
* Update env var for circleCi
* Merge genomic data bins working
* Workaround for clickhouse bug in numerical data parsing

---------

Co-authored-by: alisman <[email protected]>
@alisman alisman force-pushed the demo-rfc80-poc-add-back-custom-driver-tests branch from 4cef6e9 to 665fe8d Compare December 9, 2024 21:00
@alisman alisman changed the base branch from demo-rfc80-poc to master December 9, 2024 21:00
Copy link

sonarcloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants