New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark 'sign_tags' as a boolean value #263

Open

julien-lecomte wants to merge 1 commit into c4urself:master from julien-lecomte:fix-tags-no-sign

julien-lecomte commented Nov 7, 2022

When passed as a command line option, --(no-)sign-tags is a boolean. When only taken from the configuration, it's a string.

Because of this, string "false" later evaluate to true and signing is attempted and fails.

Working configuration:

[bumpversion]
current_version = 0.2.8
commit = true
tag = true
message = Bump version from {current_version} to {new_version}
tag_message = Release version {new_version} (previous: {current_version})

[bumpversion:file:pyproject.toml]

Broken configuration:

[bumpversion]
current_version = 0.2.8
commit = true
tag = true
sign_tags = false
message = Bump version from {current_version} to {new_version}
tag_message = Release version {new_version} (previous: {current_version})

[bumpversion:file:pyproject.toml]


          Mark 'sign_tags' as a boolean value

e6ac164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet