Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate ballot size before unmarshaling ballot #15

Open
lanterno opened this issue Oct 3, 2023 · 1 comment
Open

Validate ballot size before unmarshaling ballot #15

lanterno opened this issue Oct 3, 2023 · 1 comment

Comments

@lanterno
Copy link
Member

lanterno commented Oct 3, 2023 •
edited
Loading

This check used to exist, but it was broken causing the unmarshaling to completely misbehave.

It was removed in this PR #14

and now needs to be reviewed, and the check needs to be added again provided we add:

  1. Good test or two to validate the check is working as expected (both positive and negative cases)
  2. Test this in integration mode for this specific kind of question: select
@PascalinDe PascalinDe moved this to Todo in D-Voting Oct 4, 2023
@PascalinDe PascalinDe modified the milestone: v1.0 Nov 8, 2023
@PascalinDe PascalinDe added web frontend D-Voting frontend web backend D-Voting backend and removed web frontend D-Voting frontend web backend D-Voting backend labels Nov 8, 2023
@PascalinDe PascalinDe moved this from Todo to Backlog in D-Voting Mar 7, 2024
@ineiti
Copy link
Member

ineiti commented Mar 7, 2024

Linked with #31

@ineiti ineiti moved this from Backlog to Todo in D-Voting Mar 7, 2024
@ineiti ineiti mentioned this issue Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
D-Voting
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ineiti @lanterno @PascalinDe