Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test task description, item's 'completed' status, "Clear all completed" function #10

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

c3c1l1a
Copy link
Owner

@c3c1l1a c3c1l1a commented Jun 10, 2022

Proposed changes

The aim of this pull request is to test this todo list

The following tests were implemented

  • Test function for editing the task description.
  • Test function for updating an item's 'completed' status.
  • Test function for the "Clear all completed" function.

Type of change

  • New feature

Checklist

Copy link

@zieeco zieeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @c3c1l1a and @CrystallineButterfly,

Great work with the Testing 👏
You've done well implementing it, however, there are some issues that you still need to work on to go to the next project, but you are almost there!

To highlight 🎯

  • No linter errors.✔️
  • Nice design. ✔️
  • Descriptive PR. ✔️
  • Tests are passing ✔️
  • Good commit message ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

  • N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment on lines +42 to +43
"jest-environment-jsdom": "^28.1.1",
"jest-localstorage-mock": "^2.4.21",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[REQUIRED CHANGES]

  • Hey Team, you've done a great job with the testing however the jest testing dependencies are missing in your package.json and package-lock.json. I had to install it before I could run the test. Please install jest using
    the npm install jest command to update the dependencies. see the images below:

package.json
jest

package-lock.json
jestpack-lock json

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zieeco Thank you for the review, it was been done now!

All the best -K

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well resolved 👍🏽

Copy link

@Whoistolu Whoistolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Team

@c3c1l1a and @CrystallineButterfly

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

STATUS: APPROVED 🟢

Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Whoistolu in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants