Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: split up CI jobs #52

Merged
merged 3 commits into from
Oct 31, 2024
Merged

ci: split up CI jobs #52

merged 3 commits into from
Oct 31, 2024

Conversation

robjtede
Copy link
Member

No description provided.

Comment on lines +15 to +17
# fd --hidden -e=toml --exec-batch taplo format --check
# fd --hidden -e=toml --exec-batch taplo lint
# fd --hidden --type=file -e=md -e=yml --exec-batch prettier --check
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using taplo instead of cargo-sort is my preference but leaving it out for now

also using prettier for markdown and YAML formatting keeps things consistent, but also leaving it out for now and just commenting it here for future reference

README.md Outdated
Comment on lines 23 to 24
```toml
[dependencies]
bytesize = { version = "2", features = ["serde"]}
```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not really useful to place this in crate readmes any more since all crates.io pages suggests cargo add already

@robjtede robjtede requested a review from MrCroxx October 14, 2024 05:37
Copy link
Member Author

@robjtede robjtede Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrCroxx much of this CI setup is inspired by my other projects, happy to take questions about motivation for any changes

for example: only running tests in this file (used for the readme badge) prevents non-critical failures like formatting from surfacing there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see just tool

@MrCroxx
Copy link
Collaborator

MrCroxx commented Oct 14, 2024

Good job! Let me review it, it might takes 1-3 days because I'm not familiar with just and taplo.

@MrCroxx
Copy link
Collaborator

MrCroxx commented Oct 14, 2024

BTW. @robjtede How do you like cargo-make?

@robjtede
Copy link
Member Author

cargo-make looks incredibly verbose tbh, both in terms of task definitions and in its output.

Copy link
Collaborator

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks, @robjtede . Sorry for the late response. Just on-called for a week.

@robjtede robjtede merged commit f26df42 into master Oct 31, 2024
11 checks passed
@robjtede robjtede deleted the ci branch October 31, 2024 11:00
@MrCroxx
Copy link
Collaborator

MrCroxx commented Oct 31, 2024

Maybe we can release a new version after this PR. 🥰

Or after cleaning some feature requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants