-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: split up CI jobs #52
Conversation
4413d2b
to
cf27abb
Compare
# fd --hidden -e=toml --exec-batch taplo format --check | ||
# fd --hidden -e=toml --exec-batch taplo lint | ||
# fd --hidden --type=file -e=md -e=yml --exec-batch prettier --check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using taplo instead of cargo-sort is my preference but leaving it out for now
also using prettier for markdown and YAML formatting keeps things consistent, but also leaving it out for now and just commenting it here for future reference
README.md
Outdated
```toml | ||
[dependencies] | ||
bytesize = { version = "2", features = ["serde"]} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not really useful to place this in crate readmes any more since all crates.io pages suggests cargo add
already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrCroxx much of this CI setup is inspired by my other projects, happy to take questions about motivation for any changes
for example: only running tests in this file (used for the readme badge) prevents non-critical failures like formatting from surfacing there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see just tool
Good job! Let me review it, it might takes 1-3 days because I'm not familiar with |
BTW. @robjtede How do you like |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, @robjtede . Sorry for the late response. Just on-called for a week.
Maybe we can release a new version after this PR. 🥰 Or after cleaning some feature requests! |
No description provided.