feat: allow custom weval bin #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
reviewed
Nov 8, 2024
vados-cosmonic
force-pushed
the
feat=allow-custom-weval-bin
branch
from
ca21b33 to
8172e0a
Compare
vados-cosmonic
force-pushed
the
feat=allow-custom-weval-bin
branch
9 times, most recently
from
9ed0096 to
98cb7b9
Compare
|
NOTE: at this point once the componentize-js changes are in this branch will be able to use them, after an update to the |
|
I've merged #527 which should resolve the CI error here, updating the branch and rerunning now. |
guybedford
reviewed
Nov 25, 2024
This commit enables specifying a custom `weval` binary to use when performing AOT. Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
vados-cosmonic
force-pushed
the
feat=allow-custom-weval-bin
branch
2 times, most recently
from
1ec56e0 to
f256450
Compare
Signed-off-by: Victor Adossi <[email protected]>
vados-cosmonic
force-pushed
the
feat=allow-custom-weval-bin
branch
from
f256450 to
732e0ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables using a custom
wevalbinary fromjco(see also bytecodealliance/ComponentizeJS#156) -- the idea is to hopefully download the weval binary separately from the actual test (i.e. wherejco componentizegets run), and be able to use it w/ jco specifically via arg & env var from CI.Example failure