-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript Stubgen Command #503
Open
nicoburniske
wants to merge
53
commits into
bytecodealliance:main
Choose a base branch
from
golemcloud:ts_stubgen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update and use forked golem repos
Generate Typescript Declaration Modules and Stubs
# Conflicts: # crates/js-component-bindgen-component/src/lib.rs # package-lock.json # package.json
Updates from upstream
# Conflicts: # Cargo.lock # Cargo.toml # crates/js-component-bindgen-component/src/lib.rs # crates/js-component-bindgen/Cargo.toml # package-lock.json # package.json # src/cmd/transpile.js
Update upstream
fix js identifier function export
guybedford
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic thanks for working on upstreaming this and providing such comprehensive tests as well. It would be great to provide for ComponentizeJS / StarlingMonkey workflows.
Some initial design space questions:
- Would it make sense to extend this to full JS boilerplate creation, ie creating the JS files as well for stub implementations to fill in, possibly with // TODO comments or otherwise? It seems the missing piece remains importing the types and setting up the boilerplate and perhaps as we think about increasing automation in dev workflows this is actually what users want?
- Instead of
interfaces/namespace-package-interface.d.ts
perhaps we should consider the structureinterfaces/namespace/package/interface.d.ts
since we can do folder nesting?
I will aim to do a full review soon, thanks for your patience!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new command
stubgen
that will create all typescript declaration files from the corresponding wit types. There are rust tests for some of the complex cases{namespace}{package}{interface}.d.ts
fileWIT Exports
This simple wit, will generate the following "stub" type for the user to then implement and export from their component
test.d.ts
So then developers can import the types, and implement them.
WIT Imports
This would generate two typescript files, one for each interface
interfaces/test-canvas-canvas.d.ts
interfaces/test-types-types.d.ts