Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implementations of Intrinsic #860

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Removes implementations of rquickjs's Intrinsic trait and inlines the implementations at their call sites.

There shouldn't be anything that impacts the crate's public API or the crate's users so I'm not going to add a CHANGELOG entry.

Why am I making this change?

Intrinsic was and is meant to be an internal trait of rquickjs. They made a change to require all implementations of Intrinsic to also implement Sealed which can't be implemented by crates outside of rquickjs with the intention of blocking crates using rquickjs from implementing Intrinsic. So I'm removing our implementations of Intrinsic from our codebase so we can update rquickjs versions.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-plugin do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles merged commit d57bfc3 into main Dec 10, 2024
4 checks passed
@jeffcharles jeffcharles deleted the jc.no-more-intrinsic branch December 10, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants