Remove implementations of Intrinsic #860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Removes implementations of
rquickjs
'sIntrinsic
trait and inlines the implementations at their call sites.There shouldn't be anything that impacts the crate's public API or the crate's users so I'm not going to add a CHANGELOG entry.
Why am I making this change?
Intrinsic
was and is meant to be an internal trait ofrquickjs
. They made a change to require all implementations ofIntrinsic
to also implementSealed
which can't be implemented by crates outside of rquickjs with the intention of blocking crates using rquickjs from implementingIntrinsic
. So I'm removing our implementations ofIntrinsic
from our codebase so we can update rquickjs versions.Checklist
javy-cli
andjavy-plugin
do not require updating CHANGELOG files.